Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #445

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Release 1.2.0 #445

merged 2 commits into from
Jun 25, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jun 25, 2024

image

@hagenw hagenw requested a review from ChristianGeng June 25, 2024 11:35
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content

From what I can see the changes comprise everything that was changed.
I can find no typos in the added texts

Tests

Apart from having an @ in my home directory name the tests all pass when calling tests using the recommended python -m pytest.

However when invoking tests using the pytest commands (pytest tests or also pytest or even py.test) :

 pytest tests/
ImportError while loading conftest '/home/[email protected]/work/tools-public/audformat/tests/conftest.py'.
tests/conftest.py:7: in <module>
    import audformat.testing
E   ModuleNotFoundError: No module named 'audformat.testing'

I think that I had been using this beforehand without problem. I wonder what the reason could be for such an asymmetry.

I am approving as the way to trigger tests recommended in CONTRIBUTING.rst is working as expected.

@hagenw
Copy link
Member Author

hagenw commented Jun 25, 2024

For me the the tests also work locally when running them with pytest or pytest test. If you would like to debug this further, you could create a pull request in which you change the command that calls the tests in the CI job and see if they fail as well.

@hagenw hagenw merged commit c132807 into main Jun 25, 2024
10 checks passed
@hagenw hagenw deleted the release-1.2.0 branch June 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants